]> git.hungrycats.org Git - linux/commitdiff
ALSA: usb-line6: use the same declaration as definition in header for MIDI manufactur...
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Sun, 25 Sep 2016 13:00:20 +0000 (22:00 +0900)
committerJiri Slaby <jslaby@suse.cz>
Mon, 17 Oct 2016 07:46:19 +0000 (09:46 +0200)
commit 8da08ca03b73593d5299893bf29fc08569c3fb5f upstream.

Currently, usb-line6 module exports an array of MIDI manufacturer ID and
usb-pod module uses it. However, the declaration is not the definition in
common header. The difference is explicit length of array. Although
compiler calculates it and everything goes well, it's better to use the
same representation between definition and declaration.

This commit fills the length of array for usb-line6 module. As a small
good sub-effect, this commit suppress below warnings from static analysis
by sparse v0.5.0.

sound/usb/line6/driver.c:274:43: error: cannot size expression
sound/usb/line6/driver.c:275:16: error: cannot size expression
sound/usb/line6/driver.c:276:16: error: cannot size expression
sound/usb/line6/driver.c:277:16: error: cannot size expression

Fixes: 705ececd1c60 ("Staging: add line6 usb driver")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/staging/line6/driver.c

index 471c10c116ec823d54587c5426d79881cfc0db46..368f9915d81558735e248a9c22ba8bd48a0b61be 100644 (file)
@@ -83,7 +83,7 @@ static struct line6_properties line6_properties_table[] = {
 /*
        This is Line6's MIDI manufacturer ID.
 */
-const unsigned char line6_midi_id[] = {
+const unsigned char line6_midi_id[3] = {
        0x00, 0x01, 0x0c
 };