]> git.hungrycats.org Git - linux/commitdiff
staging: iio: cdc: fix improper return value
authorPan Bian <bianpan2016@163.com>
Sat, 3 Dec 2016 13:44:30 +0000 (21:44 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Nov 2017 08:37:27 +0000 (08:37 +0000)
[ Upstream commit 91ca1a8c584f55857b1f6ab20a1d3a1ce7a559bb ]

At the end of function ad7150_write_event_config(), directly returns 0.
As a result, the errors will be ignored by the callers. It may be better
to return variable "ret".

Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/iio/cdc/ad7150.c

index e8d0ff2d5c9b9cbd1ec0ffcb7b0c027c44beed0a..808d6ebf6c946b9482ce077a01c9585a86e156ba 100644 (file)
@@ -272,7 +272,7 @@ static int ad7150_write_event_config(struct iio_dev *indio_dev,
 error_ret:
        mutex_unlock(&chip->state_lock);
 
-       return 0;
+       return ret;
 }
 
 static int ad7150_read_event_value(struct iio_dev *indio_dev,