]> git.hungrycats.org Git - linux/commitdiff
drm/mediatek: ovl_adaptor: Add missing of_node_put()
authorJavier Carrasco <javier.carrasco.cruz@gmail.com>
Mon, 24 Jun 2024 16:43:47 +0000 (18:43 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Oct 2024 10:00:49 +0000 (12:00 +0200)
commit 5beb6fba25db235b52eab34bde8112f07bb31d75 upstream.

Error paths that exit for_each_child_of_node() need to call
of_node_put() to decerement the child refcount and avoid memory leaks.

Add the missing of_node_put().

Cc: stable@vger.kernel.org
Fixes: 453c3364632a ("drm/mediatek: Add ovl_adaptor support for MT8195")
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
Link: https://patchwork.kernel.org/project/dri-devel/patch/20240624-mtk_disp_ovl_adaptor_scoped-v1-2-9fa1e074d881@gmail.com/
Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c

index 2b62d64759181e9a280aa8fee9746bb7d63b1e5c..6068026f044d9ca2aa65c460bd5ee8ec692f9b41 100644 (file)
@@ -523,8 +523,10 @@ static int ovl_adaptor_comp_init(struct device *dev, struct component_match **ma
                }
 
                comp_pdev = of_find_device_by_node(node);
-               if (!comp_pdev)
+               if (!comp_pdev) {
+                       of_node_put(node);
                        return -EPROBE_DEFER;
+               }
 
                priv->ovl_adaptor_comp[id] = &comp_pdev->dev;