]> git.hungrycats.org Git - linux/commitdiff
usb: typec: fix unreleased fwnode_handle in typec_port_register_altmodes()
authorJavier Carrasco <javier.carrasco.cruz@gmail.com>
Mon, 21 Oct 2024 20:45:29 +0000 (22:45 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Nov 2024 15:26:44 +0000 (16:26 +0100)
commit 9581acb91eaf5bbe70086bbb6fca808220d358ba upstream.

The 'altmodes_node' fwnode_handle is never released after it is no
longer required, which leaks the resource.

Add the required call to fwnode_handle_put() when 'altmodes_node' is no
longer required.

Cc: stable@vger.kernel.org
Fixes: 7b458a4c5d73 ("usb: typec: Add typec_port_register_altmodes()")
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Link: https://lore.kernel.org/r/20241021-typec-class-fwnode_handle_put-v2-1-3281225d3d27@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/class.c

index 3d44e181dbb501ea23987a1b1e94664b8f4f5d6b..9ceb29904bbf29925ff607820d57caf414c79e57 100644 (file)
@@ -2165,6 +2165,7 @@ void typec_port_register_altmodes(struct typec_port *port,
                altmodes[index] = alt;
                index++;
        }
+       fwnode_handle_put(altmodes_node);
 }
 EXPORT_SYMBOL_GPL(typec_port_register_altmodes);