]> git.hungrycats.org Git - linux/commitdiff
drm/dp_tunnel: Switch private_obj initialization to atomic_create_state
authorMaxime Ripard <mripard@kernel.org>
Wed, 28 Jan 2026 12:43:50 +0000 (13:43 +0100)
committerMaxime Ripard <mripard@kernel.org>
Tue, 10 Feb 2026 09:06:36 +0000 (10:06 +0100)
The DP tunnel implementation relies on a drm_private_obj, that is
initialized by allocating and initializing a state, and then passing it
to drm_private_obj_init.

Since we're gradually moving away from that pattern to the more
established one relying on a atomic_create_state implementation, let's
migrate this instance to the new pattern.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://patch.msgid.link/20260128-drm-private-obj-reset-v4-6-90891fa3d3b0@redhat.com
Signed-off-by: Maxime Ripard <mripard@kernel.org>
drivers/gpu/drm/display/drm_dp_tunnel.c

index 43f13a7c79b931beb230f8afe20afa0ebcf5ed8d..536b5aaae77669936c439279c9d82db84155d5fa 100644 (file)
@@ -1497,7 +1497,22 @@ static void tunnel_group_destroy_state(struct drm_private_obj *obj, struct drm_p
        free_group_state(to_group_state(state));
 }
 
+static struct drm_private_state *tunnel_group_atomic_create_state(struct drm_private_obj *obj)
+{
+       struct drm_dp_tunnel_group_state *group_state;
+
+       group_state = kzalloc(sizeof(*group_state), GFP_KERNEL);
+       if (!group_state)
+               return ERR_PTR(-ENOMEM);
+
+       __drm_atomic_helper_private_obj_create_state(obj, &group_state->base);
+       INIT_LIST_HEAD(&group_state->tunnel_states);
+
+       return &group_state->base;
+}
+
 static const struct drm_private_state_funcs tunnel_group_funcs = {
+       .atomic_create_state = tunnel_group_atomic_create_state,
        .atomic_duplicate_state = tunnel_group_duplicate_state,
        .atomic_destroy_state = tunnel_group_destroy_state,
 };
@@ -1581,19 +1596,11 @@ EXPORT_SYMBOL(drm_dp_tunnel_atomic_get_new_state);
 
 static bool init_group(struct drm_dp_tunnel_mgr *mgr, struct drm_dp_tunnel_group *group)
 {
-       struct drm_dp_tunnel_group_state *group_state;
-
-       group_state = kzalloc(sizeof(*group_state), GFP_KERNEL);
-       if (!group_state)
-               return false;
-
-       INIT_LIST_HEAD(&group_state->tunnel_states);
-
        group->mgr = mgr;
        group->available_bw = -1;
        INIT_LIST_HEAD(&group->tunnels);
 
-       drm_atomic_private_obj_init(mgr->dev, &group->base, &group_state->base,
+       drm_atomic_private_obj_init(mgr->dev, &group->base, NULL,
                                    &tunnel_group_funcs);
 
        return true;