]> git.hungrycats.org Git - linux/commitdiff
media: v4l2-subdev: Fix stream handling for crop API
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Mon, 1 Apr 2024 23:37:25 +0000 (02:37 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 May 2024 07:49:38 +0000 (09:49 +0200)
[ Upstream commit 34d7bf1c8e59f5fbf438ee32c96389ebe41ca2e8 ]

When support for streams was added to the V4L2 subdev API, the
v4l2_subdev_crop structure was extended with a stream field, but the
field was not handled in the core code that translates the
VIDIOC_SUBDEV_[GS]_CROP ioctls to the selection API. Fix it.

Fixes: 2f91e10ee6fd ("media: subdev: add stream based configuration")
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/v4l2-core/v4l2-subdev.c

index 4c6198c48dd612241841a41d26b4de8fced6ea3d..45836f0a2b0a7a0234ac0afabfecc367d9f33115 100644 (file)
@@ -732,6 +732,7 @@ static long subdev_do_ioctl(struct file *file, unsigned int cmd, void *arg,
                memset(&sel, 0, sizeof(sel));
                sel.which = crop->which;
                sel.pad = crop->pad;
+               sel.stream = crop->stream;
                sel.target = V4L2_SEL_TGT_CROP;
 
                rval = v4l2_subdev_call(
@@ -756,6 +757,7 @@ static long subdev_do_ioctl(struct file *file, unsigned int cmd, void *arg,
                memset(&sel, 0, sizeof(sel));
                sel.which = crop->which;
                sel.pad = crop->pad;
+               sel.stream = crop->stream;
                sel.target = V4L2_SEL_TGT_CROP;
                sel.r = crop->rect;