]> git.hungrycats.org Git - linux/commitdiff
platform/x86: samsung-laptop: Initialize loca variable
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 7 Jun 2017 13:56:15 +0000 (16:56 +0300)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 11 Nov 2017 13:33:41 +0000 (13:33 +0000)
commit 0d2c95354a3b63256e92d9fb865c08902d2c9b0b upstream.

The variable is used uninitialized which might come into unexpected
behaviour on some Samsung laptops.

Initialize it to 0xffff which seems a proper value for non-supported
feature.

Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/platform/x86/samsung-laptop.c

index ce364a41842a2ad51e06c936824e3fb69a0a67b4..6c7057aab26281416efd78dc119073e3e60e783a 100644 (file)
@@ -1347,9 +1347,9 @@ static int __init samsung_sabi_init(struct samsung_laptop *samsung)
        const struct sabi_config *config = NULL;
        const struct sabi_commands *commands;
        unsigned int ifaceP;
+       int loca = 0xffff;
        int ret = 0;
        int i;
-       int loca;
 
        samsung->f0000_segment = ioremap_nocache(0xf0000, 0xffff);
        if (!samsung->f0000_segment) {