]> git.hungrycats.org Git - linux/commitdiff
net: stmmac: dwmac1000: Account for the primary MAC address for UC filtering
authorMaxime Chevallier <maxime.chevallier@bootlin.com>
Wed, 26 Aug 2026 14:04:54 +0000 (16:04 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 27 Aug 2026 17:53:27 +0000 (10:53 -0700)
The same filter slots are used to store the main MAC address as well as
the address for the unicast filter. Let's account for that when deciding
whether or not to use promisc when programming the UC list in hardware.

Fixes: 47dd7a540b8a ("net: add support for STMicroelectronics Ethernet controllers.")
Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20260826140500.616466-3-maxime.chevallier@bootlin.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c

index caac85fc08f1b60397d9ed345b91ad41be95f05f..d4ace392489153dfc7d3976f67c0195ec20cd609 100644 (file)
@@ -194,7 +194,7 @@ static void dwmac1000_set_filter(struct mac_device_info *hw,
        dwmac1000_set_mchash(ioaddr, mc_filter, mcbitslog2);
 
        /* Handle multiple unicast addresses (perfect filtering) */
-       if (netdev_uc_count(dev) > perfect_addr_number)
+       if (netdev_uc_count(dev) + 1 > perfect_addr_number)
                /* Switch to promiscuous mode if more than unicast
                 * addresses are requested than supported by hardware.
                 */