]> git.hungrycats.org Git - linux/commitdiff
HID: roccat: ryos: reject short special reports
authorJiale Yao <yaojiale02@163.com>
Thu, 24 Sep 2026 14:29:16 +0000 (22:29 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Nov 2026 17:10:51 +0000 (12:10 -0500)
commit 02f3607d0beb82e76481568bf631235e6a319b47 upstream.

The raw event callback runs before HID core validates and zero-pads the
report.  It reads the report number without checking the received length
and passes matching data to roccat_report_event(), which copies a complete
struct ryos_report_special.  A truncated report can therefore cause an
out-of-bounds read and expose adjacent data through the Roccat character
device.

Require a complete special report before inspecting or forwarding it.
Commit 47669bec44fe ("HID: asus: refactor the two workqueues and init
sequence") added the same kind of raw-event length validation to hid-asus.

Fixes: 6f3a19360545 ("HID: roccat: add support for Ryos MK keyboards")
Cc: stable@vger.kernel.org
Signed-off-by: Jiale Yao <yaojiale02@163.com>
Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hid/hid-roccat-ryos.c

index db83f42457da551dea2dc358ff569e7d45974967..85df7955b87cac84a0efafe101c823296585f443 100644 (file)
@@ -189,6 +189,9 @@ static int ryos_raw_event(struct hid_device *hdev,
                        != RYOS_USB_INTERFACE_PROTOCOL)
                return 0;
 
+       if (size < sizeof(struct ryos_report_special))
+               return 0;
+
        if (data[0] != RYOS_REPORT_NUMBER_SPECIAL)
                return 0;