]> git.hungrycats.org Git - linux/commitdiff
drm/amd/display: Remove redundant NULL check before kfree() in mod_power_create()
authorZiran Zhang <zhangcoder@yeah.net>
Sat, 27 Jun 2026 13:13:54 +0000 (21:13 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 15 Jul 2026 13:15:43 +0000 (09:15 -0400)
kfree() safely handles NULL pointers, so there is no need to check for
NULL before calling kfree().

Remove redundant NULL check.

Found by Coccinelle ifnullfree script.

Signed-off-by: Ziran Zhang <zhangcoder@yeah.net>
Reviewed-by: George Zhang <george.zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/modules/power/power.c

index db101fdb11f0c9a09b928ee3c022b255e3d24f9b..ee15c14a899ee44d6c0cb30f3700b82834ffa059 100644 (file)
@@ -270,13 +270,11 @@ struct mod_power *mod_power_create(struct dc *dc,
 fail_bad_brightness_range:
 fail_alloc_backlight_array:
        for (inst = 0; inst < edp_num; inst++)
-               if (core_power->bl_prop[inst].backlight_lut)
-                       kfree(core_power->bl_prop[inst].backlight_lut);
+               kfree(core_power->bl_prop[inst].backlight_lut);
 fail_construct:
-       for (i = 0; i < MOD_POWER_MAX_CONCURRENT_STREAMS; i++) {
-               if (core_power->map[i].psr_context)
-                       kfree(core_power->map[i].psr_context);
-       }
+       for (i = 0; i < MOD_POWER_MAX_CONCURRENT_STREAMS; i++)
+               kfree(core_power->map[i].psr_context);
+
        kfree(core_power->map);
 
 fail_alloc_map:
@@ -295,8 +293,7 @@ void mod_power_destroy(struct mod_power *mod_power)
                                MOD_POWER_TO_CORE(mod_power);
 
                for (i = 0; i < MOD_POWER_MAX_CONCURRENT_STREAMS; i++)
-                       if (core_power->map[i].psr_context)
-                               kfree(core_power->map[i].psr_context);
+                       kfree(core_power->map[i].psr_context);
 
                for (i = 0; i < core_power->num_entities; i++)
                        if (core_power->map[i].stream)
@@ -305,8 +302,7 @@ void mod_power_destroy(struct mod_power *mod_power)
                kfree(core_power->map);
 
                for (i = 0; i < MAX_NUM_EDP; i++)
-                       if (core_power->bl_prop[i].backlight_lut)
-                               kfree(core_power->bl_prop[i].backlight_lut);
+                       kfree(core_power->bl_prop[i].backlight_lut);
 
                kfree(core_power);
        }