]> git.hungrycats.org Git - linux/commitdiff
ARM: mm: use pteval_t to represent page protection values
authorWill Deacon <will.deacon@arm.com>
Tue, 18 Sep 2012 18:18:35 +0000 (19:18 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 11 Jan 2013 17:07:16 +0000 (09:07 -0800)
commit 864aa04cd02979c2c755cb28b5f4fe56039171c0 upstream.

When updating the page protection map after calculating the user_pgprot
value, the base protection map is temporarily stored in an unsigned long
type, causing truncation of the protection bits when LPAE is enabled.
This effectively means that calls to mprotect() will corrupt the upper
page attributes, clearing the XN bit unconditionally.

This patch uses pteval_t to store the intermediate protection values,
preserving the upper bits for 64-bit descriptors.

Acked-by: Nicolas Pitre <nico@linaro.org>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/arm/mm/mmu.c

index 7d419193d49a14325ffe17ddb7c2da2b4cede267..5df549244d670aa9ad2c2730f2f41c980b8c7a40 100644 (file)
@@ -497,7 +497,7 @@ static void __init build_mem_type_table(void)
 #endif
 
        for (i = 0; i < 16; i++) {
-               unsigned long v = pgprot_val(protection_map[i]);
+               pteval_t v = pgprot_val(protection_map[i]);
                protection_map[i] = __pgprot(v | user_pgprot);
        }