isdn/gigaset: reduce syslog spam

commit 7d060ed2877ff6d00e7238226edbaf91493d6d0b upstream.

Downgrade some error messages which occur frequently during
normal operation to debug messages.

Impact: logging
Signed-off-by: Tilman Schmidt <tilman@imap.cc>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

diff --git a/drivers/isdn/gigaset/capi.c b/drivers/isdn/gigaset/capi.c
index 6fbe8999c4191e6b5b7d1ac78512c1135803f4c5..9e168270b3a1a1c6caee445a64410cef62ab4d7d 100644 (file)
--- a/drivers/isdn/gigaset/capi.c
+++ b/drivers/isdn/gigaset/capi.c
@@ -378,13 +378,13 @@ void gigaset_skb_sent(struct bc_state *bcs, struct sk_buff *dskb)
        ++bcs->trans_up;
 
        if (!ap) {
-               dev_err(cs->dev, "%s: no application\n", __func__);
+               gig_dbg(DEBUG_MCMD, "%s: application gone", __func__);
                return;
        }
 
        /* don't send further B3 messages if disconnected */
        if (bcs->apconnstate < APCONN_ACTIVE) {
-               gig_dbg(DEBUG_LLDATA, "disconnected, discarding ack");
+               gig_dbg(DEBUG_MCMD, "%s: disconnected", __func__);
                return;
        }
 
@@ -422,13 +422,14 @@ void gigaset_skb_rcvd(struct bc_state *bcs, struct sk_buff *skb)
        bcs->trans_down++;
 
        if (!ap) {
-               dev_err(cs->dev, "%s: no application\n", __func__);
+               gig_dbg(DEBUG_MCMD, "%s: application gone", __func__);
+               dev_kfree_skb_any(skb);
                return;
        }
 
        /* don't send further B3 messages if disconnected */
        if (bcs->apconnstate < APCONN_ACTIVE) {
-               gig_dbg(DEBUG_LLDATA, "disconnected, discarding data");
+               gig_dbg(DEBUG_MCMD, "%s: disconnected", __func__);
                dev_kfree_skb_any(skb);
                return;
        }
@@ -747,7 +748,7 @@ void gigaset_isdn_connD(struct bc_state *bcs)
        ap = bcs->ap;
        if (!ap) {
                spin_unlock_irqrestore(&bcs->aplock, flags);
-               dev_err(cs->dev, "%s: no application\n", __func__);
+               gig_dbg(DEBUG_CMD, "%s: application gone", __func__);
                return;
        }
        if (bcs->apconnstate == APCONN_NONE) {
@@ -843,7 +844,7 @@ void gigaset_isdn_connB(struct bc_state *bcs)
        ap = bcs->ap;
        if (!ap) {
                spin_unlock_irqrestore(&bcs->aplock, flags);
-               dev_err(cs->dev, "%s: no application\n", __func__);
+               gig_dbg(DEBUG_CMD, "%s: application gone", __func__);
                return;
        }
        if (!bcs->apconnstate) {
@@ -901,13 +902,12 @@ void gigaset_isdn_connB(struct bc_state *bcs)
  */
 void gigaset_isdn_hupB(struct bc_state *bcs)
 {
-       struct cardstate *cs = bcs->cs;
        struct gigaset_capi_appl *ap = bcs->ap;
 
        /* ToDo: assure order of DISCONNECT_B3_IND and DISCONNECT_IND ? */
 
        if (!ap) {
-               dev_err(cs->dev, "%s: no application\n", __func__);
+               gig_dbg(DEBUG_CMD, "%s: application gone", __func__);
                return;
        }