[PATCH] ppa needs to scsi_unregister(host)

When umounting a ppa device, I see (2.6.0-test3):

Releasing ppa0
Iomega VPI0 (ppa) interface did not call scsi_unregister
Call Trace:
 [<f89aeca6>] exit_this_scsi_driver+0xb6/0xfa [ppa]
 [<c013c08d>] sys_delete_module+0x18d/0x1e0
 [<c0155276>] do_munmap+0x136/0x1b0
 [<c0155333>] sys_munmap+0x43/0x70
 [<c0109657>] syscall_call+0x7/0xb

so ppa needs to call scsi_unregister().
Is this all that's needed?

--
~Randy

patch_name:	scsi_ppa_unreg.patch
patch_version:	2003-08-15.09:46:30
author:		Randy.Dunlap <rddunlap@osdl.org>
description:	ppa driver needs to call scsi_unregister(host);
product:	Linux
product_versions: 260-815
maintainer:	campbell@torque.net
diffstat:	=
 drivers/scsi/ppa.c |    1 +
 1 files changed, 1 insertion(+)

diff --git a/drivers/scsi/ppa.c b/drivers/scsi/ppa.c
index a30d9fbe6e168f7ef384838f73a308aebfcbe892..d2088d3da0c85159365a0bc51035066ebcac93bd 100644 (file)
--- a/drivers/scsi/ppa.c
+++ b/drivers/scsi/ppa.c
@@ -76,6 +76,7 @@ int ppa_release(struct Scsi_Host *host)
     int host_no = host->unique_id;
 
     printk("Releasing ppa%i\n", host_no);
+    scsi_unregister(host);
     parport_unregister_device(ppa_hosts[host_no].dev);
     return 0;
 }