]> git.hungrycats.org Git - linux/commitdiff
HID: amd_sfh: Use report type from request node
authorBasavaraj Natikar <Basavaraj.Natikar@amd.com>
Tue, 6 Oct 2026 10:37:54 +0000 (16:07 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Nov 2026 17:10:49 +0000 (12:10 -0500)
commit 85f1bea97f1909f81577cfcf3e4db9017e7f5337 upstream.

Use report type from request node while sending feature and input reports
to HID core. The cli_data report type array is never assigned and
feature reports are sent as input reports.

Fixes: 1434f9fc0e47 ("SFH: Create HID report to Enable support of AMD sensor fusion Hub (SFH)")
Closes: https://github.com/ublue-os/bazzite/issues/5796
Cc: stable@vger.kernel.org
Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hid/amd-sfh-hid/amd_sfh_client.c

index ae6add0b9ce3fa637be4f1b3957f8033faa0277b..a68b275f0456b48c5391bdbfdfcedbee8d49d233 100644 (file)
@@ -95,7 +95,7 @@ void amd_sfh_work(struct work_struct *work)
                                                    cli_data->feature_report[current_index]);
                if (report_size)
                        hid_input_report(cli_data->hid_sensor_hubs[current_index],
-                                        cli_data->report_type[current_index],
+                                        node_type,
                                         cli_data->feature_report[current_index], report_size, 0);
                else
                        pr_err("AMDSFH: Invalid report size\n");
@@ -104,7 +104,7 @@ void amd_sfh_work(struct work_struct *work)
                report_size = mp2_ops->get_in_rep(current_index, sensor_index, report_id, in_data);
                if (report_size)
                        hid_input_report(cli_data->hid_sensor_hubs[current_index],
-                                        cli_data->report_type[current_index],
+                                        node_type,
                                         in_data->input_report[current_index], report_size, 0);
                else
                        pr_err("AMDSFH: Invalid report size\n");