f2fs: preserve i_mode if __f2fs_set_acl() fails

commit 14af20fcb1833dd776822361891963c90f7b0262 upstream.

When changing a file's acl mask, __f2fs_set_acl() will first set the
group bits of i_mode to the value of the mask, and only then set the
actual extended attribute representing the new acl.

If the second part fails (due to lack of space, for example) and the
file had no acl attribute to begin with, the system will from now on
assume that the mask permission bits are actual group permission bits,
potentially granting access to the wrong users.

Prevent this by only changing the inode mode after the acl has been set.

Signed-off-by: Ernesto A. Fernández <ernesto.mnd.fernandez@gmail.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
[bwh: Backported to 3.16: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>

diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c
index 6e79f11332919062cc4dccf11fa3fc89a422323f..e6e2dd4779f05f708f2d959a2ebeb5a2c6937591 100644 (file)
--- a/fs/f2fs/acl.c
+++ b/fs/f2fs/acl.c
@@ -202,6 +202,7 @@ static int __f2fs_set_acl(struct inode *inode, int type,
        void *value = NULL;
        size_t size = 0;
        int error;
+       umode_t mode = inode->i_mode;
 
        if (acl) {
                error = posix_acl_valid(acl);
@@ -213,10 +214,10 @@ static int __f2fs_set_acl(struct inode *inode, int type,
        case ACL_TYPE_ACCESS:
                name_index = F2FS_XATTR_INDEX_POSIX_ACL_ACCESS;
                if (acl && !ipage) {
-                       error = posix_acl_update_mode(inode, &inode->i_mode, &acl);
+                       error = posix_acl_update_mode(inode, &mode, &acl);
                        if (error)
                                return error;
-                       set_acl_inode(fi, inode->i_mode);
+                       set_acl_inode(fi, mode);
                }
                break;