]> git.hungrycats.org Git - linux/commitdiff
ASoC: imx-wm8962: Add a missing error check
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 10 Jun 2015 15:37:23 +0000 (18:37 +0300)
committerSasha Levin <sasha.levin@oracle.com>
Tue, 4 Aug 2015 18:18:32 +0000 (14:18 -0400)
[ Upstream commit 474ff0ae23b834e9fc18374d14bb5f3e7b3828b4 ]

My static checker complains that:

sound/soc/fsl/imx-wm8962.c:196 imx_wm8962_probe() warn:
we tested 'ret' before and it was 'false'

The intent was that we use "ret" to check imx_audmux_v2_configure_port().

Fixes: 8de2ae2a7f1f ('ASoC: fsl: add imx-wm8962 machine driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Otherwise, Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
sound/soc/fsl/imx-wm8962.c

index 3a3d17ce6ba40feea5dc6582693d7c1ee846ef13..6644525994970008c27b2027315171d24f6e9b3b 100644 (file)
@@ -190,7 +190,7 @@ static int imx_wm8962_probe(struct platform_device *pdev)
                dev_err(&pdev->dev, "audmux internal port setup failed\n");
                return ret;
        }
-       imx_audmux_v2_configure_port(ext_port,
+       ret = imx_audmux_v2_configure_port(ext_port,
                        IMX_AUDMUX_V2_PTCR_SYN,
                        IMX_AUDMUX_V2_PDCR_RXDSEL(int_port));
        if (ret) {