drm/amdkfd: add sanity check in svm_range_is_valid

to prevent svm range to be overflow or underflow.

Signed-off-by: Eric Huang <jinhuieric.huang@amd.com>
Reviewed-by: Philip Yang <philip.yang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
index 0900bb23349ef78b8da7a046d6154327bc0b0af9..30ad10bbd47ee18776d168556840b240f8e2cbed 100644 (file)
--- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
@@ -3473,7 +3473,13 @@ svm_range_is_valid(struct kfd_process *p, uint64_t start, uint64_t size)
        unsigned long start_unchg = start;
 
        start <<= PAGE_SHIFT;
-       end = start + (size << PAGE_SHIFT);
+
+       if (size == 0)
+               return -EINVAL;
+
+       if (check_add_overflow(start, size << PAGE_SHIFT, &end))
+               return -EOVERFLOW;
+
        do {
                vma = vma_lookup(p->mm, start);
                if (!vma || (vma->vm_flags & device_vma))