]> git.hungrycats.org Git - bees/commitdiff
context: demote "abandoned toxic match" to debug log level
authorKai Krakow <kai@kaishome.de>
Sun, 30 Jun 2024 14:27:20 +0000 (16:27 +0200)
committerZygo Blaxell <bees@furryterror.org>
Sun, 19 Jan 2025 05:59:22 +0000 (00:59 -0500)
This log message creates a overwhelmingly lot of messages in the system
journal, leading to write-back flushing storms under high activity. As
it is a work-around message, it is probably only useful to developers,
thus demote to debug level.

This fixes latency spikes in desktop usage after adding a lot of new
files, especially since systemd-journal starts to flush caches if it
sees memory pressure.

Signed-off-by: Kai Krakow <kai@kaishome.de>
src/bees-context.cc

index 6d484a513064da051700f953ff9d92c7211becbe..1f1ed7e9336cb4592da4d63ace882c78f0f28a1d 100644 (file)
@@ -534,7 +534,7 @@ BeesContext::scan_one_extent(const BeesFileRange &bfr, const Extent &e)
 
                        // Hash is toxic
                        if (found_addr.is_toxic()) {
-                               BEESLOGWARN("WORKAROUND: abandoned toxic match for hash " << hash << " addr " << found_addr << " matching bbd " << bbd);
+                               BEESLOGDEBUG("WORKAROUND: abandoned toxic match for hash " << hash << " addr " << found_addr << " matching bbd " << bbd);
                                // Don't push these back in because we'll never delete them.
                                // Extents may become non-toxic so give them a chance to expire.
                                // hash_table->push_front_hash_addr(hash, found_addr);