]> git.hungrycats.org Git - linux/commitdiff
usb: dwc3: replace %p with %pK
authorFelipe Balbi <felipe.balbi@linux.intel.com>
Wed, 17 May 2017 12:57:45 +0000 (15:57 +0300)
committerSasha Levin <alexander.levin@verizon.com>
Mon, 31 Jul 2017 17:37:52 +0000 (13:37 -0400)
[ Upstream commit 04fb365c453e14ff9e8a28f1c46050d920a27a4a ]

%p will leak kernel pointers, so let's not expose the information on
dmesg and instead use %pK. %pK will only show the actual addresses if
explicitly enabled under /proc/sys/kernel/kptr_restrict.

Cc: <stable@vger.kernel.org>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
drivers/usb/dwc3/dwc3-st.c
drivers/usb/dwc3/gadget.c

index 4a1a543deeda7c61b0b8378fc9a1e36553f44372..da885c3bc33f08fae8dd35ea802712d2b3145c14 100644 (file)
@@ -227,7 +227,7 @@ static int st_dwc3_probe(struct platform_device *pdev)
 
        dwc3_data->syscfg_reg_off = res->start;
 
-       dev_vdbg(&pdev->dev, "glue-logic addr 0x%p, syscfg-reg offset 0x%x\n",
+       dev_vdbg(&pdev->dev, "glue-logic addr 0x%pK, syscfg-reg offset 0x%x\n",
                 dwc3_data->glue_base, dwc3_data->syscfg_reg_off);
 
        dwc3_data->rstc_pwrdn = devm_reset_control_get(dev, "powerdown");
index 48412e4afb1b523a3bbeaffa9954333a1ee5af38..ff56aaa00bf73a743fffe9fbb4630183940612aa 100644 (file)
@@ -1202,7 +1202,7 @@ static int dwc3_gadget_ep_queue(struct usb_ep *ep, struct usb_request *request,
                goto out;
        }
 
-       if (WARN(req->dep != dep, "request %p belongs to '%s'\n",
+       if (WARN(req->dep != dep, "request %pK belongs to '%s'\n",
                                request, req->dep->name)) {
                ret = -EINVAL;
                goto out;
@@ -1249,7 +1249,7 @@ static int dwc3_gadget_ep_dequeue(struct usb_ep *ep,
                        dwc3_stop_active_transfer(dwc, dep->number, true);
                        goto out1;
                }
-               dev_err(dwc->dev, "request %p was not queued to %s\n",
+               dev_err(dwc->dev, "request %pK was not queued to %s\n",
                                request, ep->name);
                ret = -EINVAL;
                goto out0;
@@ -1854,7 +1854,7 @@ static int __dwc3_cleanup_done_trbs(struct dwc3 *dwc, struct dwc3_ep *dep,
                 * would help. Lets hope that if this occurs, someone
                 * fixes the root cause instead of looking away :)
                 */
-               dev_err(dwc->dev, "%s's TRB (%p) still owned by HW\n",
+               dev_err(dwc->dev, "%s's TRB (%pK) still owned by HW\n",
                                dep->name, trb);
 
        count = trb->size & DWC3_TRB_SIZE_MASK;