]> git.hungrycats.org Git - linux/commitdiff
staging: iio: accel: fix error check
authorLuis de Bethencourt <luisbg@osg.samsung.com>
Wed, 22 Jun 2016 19:43:30 +0000 (20:43 +0100)
committerSasha Levin <alexander.levin@verizon.com>
Sat, 20 Aug 2016 03:08:43 +0000 (23:08 -0400)
[ Upstream commit ef3149eb3ddb7f9125e11c90f8330e371b55cffd ]

sca3000_read_ctrl_reg() returns a negative number on failure, check for
this instead of zero.

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
drivers/staging/iio/accel/sca3000_core.c

index b614f272b5f4b1b40071d4ea5e11678453a1f431..851fcfa98068259aedba2767a3c11767ea097501 100644 (file)
@@ -595,7 +595,7 @@ static ssize_t sca3000_read_frequency(struct device *dev,
                goto error_ret_mut;
        ret = sca3000_read_ctrl_reg(st, SCA3000_REG_CTRL_SEL_OUT_CTRL);
        mutex_unlock(&st->lock);
-       if (ret)
+       if (ret < 0)
                goto error_ret;
        val = ret;
        if (base_freq > 0)