]> git.hungrycats.org Git - linux/commitdiff
ext4: fix potential integer overflow
authorInsu Yun <wuninsu@gmail.com>
Fri, 12 Feb 2016 06:15:59 +0000 (01:15 -0500)
committerJiri Slaby <jslaby@suse.cz>
Wed, 24 Feb 2016 09:23:19 +0000 (10:23 +0100)
commit 46901760b46064964b41015d00c140c83aa05bcf upstream.

Since sizeof(ext_new_group_data) > sizeof(ext_new_flex_group_data),
integer overflow could be happened.
Therefore, need to fix integer overflow sanitization.

Signed-off-by: Insu Yun <wuninsu@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
fs/ext4/resize.c

index 831cb305c63fd527bd3f5e3f7d223f9c0da6b0b1..ae8ce49c0437108349193d14a46d334a35571a2e 100644 (file)
@@ -186,7 +186,7 @@ static struct ext4_new_flex_group_data *alloc_flex_gd(unsigned long flexbg_size)
        if (flex_gd == NULL)
                goto out3;
 
-       if (flexbg_size >= UINT_MAX / sizeof(struct ext4_new_flex_group_data))
+       if (flexbg_size >= UINT_MAX / sizeof(struct ext4_new_group_data))
                goto out2;
        flex_gd->count = flexbg_size;