]> git.hungrycats.org Git - linux/commitdiff
crypto: af_alg - Fix socket double-free when accept fails
authorHerbert Xu <herbert@gondor.apana.org.au>
Wed, 30 Dec 2015 12:24:17 +0000 (20:24 +0800)
committerJiri Slaby <jslaby@suse.cz>
Wed, 24 Feb 2016 08:24:09 +0000 (09:24 +0100)
commit a383292c86663bbc31ac62cc0c04fc77504636a6 upstream.

When we fail an accept(2) call we will end up freeing the socket
twice, once due to the direct sk_free call and once again through
newsock.

This patch fixes this by removing the sk_free call.

Reported-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
crypto/af_alg.c

index d7fefeb3d1a7bd8643bf056da3d46ab4467f9edb..0ca108f3c84084278c026173302cccfdce0a487f 100644 (file)
@@ -275,10 +275,8 @@ int af_alg_accept(struct sock *sk, struct socket *newsock)
        security_sk_clone(sk, sk2);
 
        err = type->accept(ask->private, sk2);
-       if (err) {
-               sk_free(sk2);
+       if (err)
                goto unlock;
-       }
 
        sk2->sk_family = PF_ALG;