]> git.hungrycats.org Git - linux/commitdiff
gro: use min_t() in skb_gro_reset_offset()
authorEric Dumazet <edumazet@google.com>
Wed, 11 Jan 2017 03:52:43 +0000 (19:52 -0800)
committerJiri Slaby <jslaby@suse.cz>
Thu, 26 Jan 2017 16:40:28 +0000 (17:40 +0100)
[ Upstream commit 7cfd5fd5a9813f1430290d20c0fead9b4582a307 ]

On 32bit arches, (skb->end - skb->data) is not 'unsigned int',
so we shall use min_t() instead of min() to avoid a compiler error.

Fixes: 1272ce87fa01 ("gro: Enter slow-path if there is no tailroom")
Reported-by: kernel test robot <fengguang.wu@intel.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
net/core/dev.c

index 3595e536e0fd6a98d2c0f6a9dfcefb1c033c1d57..6b0ddf661f924144de6501a195bd78e1dc35237f 100644 (file)
@@ -3969,8 +3969,9 @@ static void skb_gro_reset_offset(struct sk_buff *skb)
            pinfo->nr_frags &&
            !PageHighMem(skb_frag_page(frag0))) {
                NAPI_GRO_CB(skb)->frag0 = skb_frag_address(frag0);
-               NAPI_GRO_CB(skb)->frag0_len = min(skb_frag_size(frag0),
-                                                 skb->end - skb->tail);
+               NAPI_GRO_CB(skb)->frag0_len = min_t(unsigned int,
+                                                   skb_frag_size(frag0),
+                                                   skb->end - skb->tail);
        }
 }