[PATCH] signal failures in nightly LTP test

On 13 Sep 2002, Paul Larson wrote:
>
> The nightly LTP test against the 2.5 kernel bk tree last night turned up
> some test failures we don't normally see.  These failures did not show
> up in the run from the previous night.

[...]
> I found what was breaking this, looks like it was this change from your
> shared thread signals patch:
> -	if (sig < 1 || sig > _NSIG ||
> -	    (act && (sig == SIGKILL || sig == SIGSTOP)))
> +	if (sig < 1 || sig > _NSIG || (act && sig_kernel_only(sig)))

This fixes this bug and a number of others in the same class - the
signal behavior bitmasks should never be consulted before making sure
that the signal is in the word range.

diff --git a/kernel/signal.c b/kernel/signal.c
index c5385ae3282a7e074a63e1b8c7fb8bbb968c87d4..3052e34af8cc54dbd6a696dc02dfc356fb74d440 100644 (file)
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -118,14 +118,18 @@ int max_queued_signals = 1024;
 #define T(sig, mask) \
        ((1UL << (sig)) & mask)
 
-#define sig_user_specific(sig)         T(sig, SIG_USER_SPECIFIC_MASK)
+#define sig_user_specific(sig) \
+               (((sig) < SIGRTMIN)  && T(sig, SIG_USER_SPECIFIC_MASK))
 #define sig_user_load_balance(sig) \
-               (T(sig, SIG_USER_LOAD_BALANCE_MASK) || ((sig) >= SIGRTMIN))
-#define sig_kernel_specific(sig)       T(sig, SIG_KERNEL_SPECIFIC_MASK)
+               (((sig) >= SIGRTMIN) || T(sig, SIG_USER_LOAD_BALANCE_MASK))
+#define sig_kernel_specific(sig) \
+               (((sig) < SIGRTMIN)  && T(sig, SIG_KERNEL_SPECIFIC_MASK))
 #define sig_kernel_broadcast(sig) \
-               (T(sig, SIG_KERNEL_BROADCAST_MASK) || ((sig) >= SIGRTMIN))
-#define sig_kernel_only(sig)           T(sig, SIG_KERNEL_ONLY_MASK)
-#define sig_kernel_coredump(sig)       T(sig, SIG_KERNEL_COREDUMP_MASK)
+               (((sig) >= SIGRTMIN) || T(sig, SIG_KERNEL_BROADCAST_MASK))
+#define sig_kernel_only(sig) \
+               (((sig) < SIGRTMIN)  && T(sig, SIG_KERNEL_ONLY_MASK))
+#define sig_kernel_coredump(sig) \
+               (((sig) < SIGRTMIN)  && T(sig, SIG_KERNEL_COREDUMP_MASK))
 
 #define sig_user_defined(t, sig) \
        (((t)->sig->action[(sig)-1].sa.sa_handler != SIG_DFL) &&        \