]> git.hungrycats.org Git - linux/commitdiff
cifs: cifs_inval_name_dfs_link_error: correct the check for fullpath
authorGleb Korobeynikov <gkorobeynikov@astralinux.ru>
Thu, 8 Aug 2024 15:47:48 +0000 (18:47 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Aug 2024 13:34:24 +0000 (15:34 +0200)
[ Upstream commit 36bb22a08a69d9984a8399c07310d18b115eae20 ]

Replace the always-true check tcon->origin_fullpath with
check of server->leaf_fullpath

See https://bugzilla.kernel.org/show_bug.cgi?id=219083

The check of the new @tcon will always be true during mounting,
since @tcon->origin_fullpath will only be set after the tree is
connected to the latest common resource, as well as checking if
the prefix paths from it are fully accessible.

Fixes: 3ae872de4107 ("smb: client: fix shared DFS root mounts with different prefixes")
Reviewed-by: Paulo Alcantara (Red Hat) <pc@manguebit.com>
Signed-off-by: Gleb Korobeynikov <gkorobeynikov@astralinux.ru>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/smb/client/misc.c

index 07c468ddb88a89d65f8a48433a055759deb3da26..65d4b72b4d51a9ef8b0bd6d52ac948f8bbf272ff 100644 (file)
@@ -1288,6 +1288,7 @@ int cifs_inval_name_dfs_link_error(const unsigned int xid,
                                   const char *full_path,
                                   bool *islink)
 {
+       struct TCP_Server_Info *server = tcon->ses->server;
        struct cifs_ses *ses = tcon->ses;
        size_t len;
        char *path;
@@ -1304,12 +1305,12 @@ int cifs_inval_name_dfs_link_error(const unsigned int xid,
            !is_tcon_dfs(tcon))
                return 0;
 
-       spin_lock(&tcon->tc_lock);
-       if (!tcon->origin_fullpath) {
-               spin_unlock(&tcon->tc_lock);
+       spin_lock(&server->srv_lock);
+       if (!server->leaf_fullpath) {
+               spin_unlock(&server->srv_lock);
                return 0;
        }
-       spin_unlock(&tcon->tc_lock);
+       spin_unlock(&server->srv_lock);
 
        /*
         * Slow path - tcon is DFS and @full_path has prefix path, so attempt