]> git.hungrycats.org Git - linux/commitdiff
qeth: repair crash in qeth_l3_vlan_rx_kill_vid()
authorFrank Blaschka <frank.blaschka@de.ibm.com>
Tue, 24 Jul 2012 22:34:29 +0000 (22:34 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Aug 2012 15:31:38 +0000 (08:31 -0700)
commit eabfbe6230ee7363681e7a561948d362b87169f0 upstream.

Commit efc73f4b "net: Fix memory leak - vlan_info struct" adds deletion of
VLAN 0 for devices with feature NETIF_F_HW_VLAN_FILTER. For driver
qeth these are the layer 3 devices. Usually there exists no
separate vlan net_device for VLAN 0. Thus the qeth functions
qeth_l3_free_vlan_addresses4() and qeth_l3_free_vlan_addresses6()
require an extra checking if function __vlan_find_dev_deep()
returns with a net_device.

Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/s390/net/qeth_l3_main.c

index f859216076867b805548085ee1ea86ae5d4103e8..951b6cf086af60c4af05961a56f74ec08856848b 100644 (file)
@@ -1818,6 +1818,8 @@ static void qeth_l3_free_vlan_addresses4(struct qeth_card *card,
        QETH_CARD_TEXT(card, 4, "frvaddr4");
 
        netdev = __vlan_find_dev_deep(card->dev, vid);
+       if (!netdev)
+               return;
        in_dev = in_dev_get(netdev);
        if (!in_dev)
                return;
@@ -1846,6 +1848,8 @@ static void qeth_l3_free_vlan_addresses6(struct qeth_card *card,
        QETH_CARD_TEXT(card, 4, "frvaddr6");
 
        netdev = __vlan_find_dev_deep(card->dev, vid);
+       if (!netdev)
+               return;
        in6_dev = in6_dev_get(netdev);
        if (!in6_dev)
                return;