]> git.hungrycats.org Git - linux/commitdiff
rndis_wlan: harmless issue calling set_bit()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 14 May 2015 08:37:50 +0000 (11:37 +0300)
committerZefan Li <lizefan@huawei.com>
Thu, 22 Oct 2015 01:20:02 +0000 (09:20 +0800)
commit e3958e9d60b4570fff709f397ef5c6b8483f40f7 upstream.

These are used like:

set_bit(WORK_LINK_UP, &priv->work_pending);

The problem is that set_bit() takes the actual bit number and not a mask
so static checkers get upset.  It doesn't affect run time because we do
it consistently, but we may as well clean it up.

Fixes: 6010ce07a66c ('rndis_wlan: do link-down state change in worker thread')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Zefan Li <lizefan@huawei.com>
drivers/net/wireless/rndis_wlan.c

index d66e2980bc27bab54ddd06867a8fccd50f6cfb0c..414ac49af480e1ad9a562e2011dd7b4dac7eeba1 100644 (file)
@@ -407,9 +407,9 @@ struct ndis_80211_pmkid {
 #define CAP_MODE_80211G                4
 #define CAP_MODE_MASK          7
 
-#define WORK_LINK_UP           (1<<0)
-#define WORK_LINK_DOWN         (1<<1)
-#define WORK_SET_MULTICAST_LIST        (1<<2)
+#define WORK_LINK_UP           0
+#define WORK_LINK_DOWN         1
+#define WORK_SET_MULTICAST_LIST        2
 
 #define RNDIS_WLAN_ALG_NONE    0
 #define RNDIS_WLAN_ALG_WEP     (1<<0)