]> git.hungrycats.org Git - linux/commitdiff
drm/xe: Check result of drmm_mutex_init()
authorMichal Wajdeczko <michal.wajdeczko@intel.com>
Tue, 9 Apr 2024 15:31:32 +0000 (17:31 +0200)
committerLucas De Marchi <lucas.demarchi@intel.com>
Wed, 24 Apr 2024 22:37:06 +0000 (15:37 -0700)
Although it's unlikely that drmm_mutex_init() will fail during
driver initialization, however we shouldn't ignore this case.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240409153132.1111-1-michal.wajdeczko@intel.com
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
drivers/gpu/drm/xe/xe_device.c

index a5b4a9643a7881b3fafa44cff9c50e44b5236c87..47db4bc9f12c11801b55e36b4894b9af447d527f 100644 (file)
@@ -274,7 +274,10 @@ struct xe_device *xe_device_create(struct pci_dev *pdev,
 
        init_waitqueue_head(&xe->ufence_wq);
 
-       drmm_mutex_init(&xe->drm, &xe->usm.lock);
+       err = drmm_mutex_init(&xe->drm, &xe->usm.lock);
+       if (err)
+               goto err;
+
        xa_init_flags(&xe->usm.asid_to_vm, XA_FLAGS_ALLOC);
 
        if (IS_ENABLED(CONFIG_DRM_XE_DEBUG)) {