[PATCH] d_lookup forgotten spin_unlock()

From: Nikita Danilov, Maneesh Soni

d_lookup() is forgetting to release the lock when the rename race happens.

diff --git a/fs/dcache.c b/fs/dcache.c
index bc81b85309e094df7019deb1eb05592d642a2d0f..bd561bf0697975a1666f34c0aa088ea353755eab 100644 (file)
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -995,12 +995,12 @@ struct dentry * d_lookup(struct dentry * parent, struct qstr * name)
                /*
                 * If dentry is moved, fail the lookup
                 */ 
-               if (unlikely(move_count != dentry->d_move_count)) 
-                       break;
-               if (!d_unhashed(dentry)) {
-                       atomic_inc(&dentry->d_count);
-                       dentry->d_vfs_flags |= DCACHE_REFERENCED;
-                       found = dentry;
+               if (likely(move_count == dentry->d_move_count)) {
+                       if (!d_unhashed(dentry)) {
+                               atomic_inc(&dentry->d_count);
+                               dentry->d_vfs_flags |= DCACHE_REFERENCED;
+                               found = dentry;
+                       }
                }
                spin_unlock(&dentry->d_lock);
                break;