]> git.hungrycats.org Git - linux/commitdiff
i3c: master: svc: fix check wrong status register in irq handler
authorFrank Li <Frank.Li@nxp.com>
Mon, 23 Oct 2023 16:16:56 +0000 (12:16 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 28 Nov 2023 17:15:09 +0000 (17:15 +0000)
commit 225d5ef048c4ed01a475c95d94833bd7dd61072d upstream.

svc_i3c_master_irq_handler() wrongly checks register SVC_I3C_MINTMASKED. It
should be SVC_I3C_MSTATUS.

Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver")
Cc: <stable@vger.kernel.org>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
Link: https://lore.kernel.org/r/20231023161658.3890811-5-Frank.Li@nxp.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/i3c/master/svc-i3c-master.c

index a0d3b2483ae77eaed2a600bd050571e7818fc436..0e300ec7f8e92637c5aebdaae1f4da574e41dac6 100644 (file)
@@ -477,7 +477,7 @@ reenable_ibis:
 static irqreturn_t svc_i3c_master_irq_handler(int irq, void *dev_id)
 {
        struct svc_i3c_master *master = (struct svc_i3c_master *)dev_id;
-       u32 active = readl(master->regs + SVC_I3C_MINTMASKED);
+       u32 active = readl(master->regs + SVC_I3C_MSTATUS);
 
        if (!SVC_I3C_MSTATUS_SLVSTART(active))
                return IRQ_NONE;