]> git.hungrycats.org Git - linux/commitdiff
drm/v3d: Use write_to_buffer() helper in performance query copy
authorMaíra Canal <mcanal@igalia.com>
Fri, 3 Jul 2026 15:33:36 +0000 (12:33 -0300)
committerMaíra Canal <mcanal@igalia.com>
Tue, 7 Jul 2026 21:21:42 +0000 (18:21 -0300)
The copy of performance query results to the output buffer open-codes
the 32-bit/64-bit selection with two nearly identical loops. As the
write_to_buffer() helper already encapsulates the do_64bit decision,
use it instead of open-coding it.

Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Link: https://patch.msgid.link/20260703-v3d-cpu-job-fixes-v3-3-bc51b1f3eeb5@igalia.com
Signed-off-by: Maíra Canal <mcanal@igalia.com>
drivers/gpu/drm/v3d/v3d_sched.c

index 5f33d379459855e50af120635c15b9dadccb0f72..c49b71b6e6ee910c81ddf8da184bbb202144ab37 100644 (file)
@@ -587,15 +587,8 @@ v3d_write_performance_query_result(struct v3d_cpu_job *job, void *data,
 
                v3d_perfmon_stop(v3d, perfmon, true);
 
-               if (job->copy.do_64bit) {
-                       for (j = 0; j < perfmon->ncounters; j++)
-                               write_to_buffer_64(data, offset + j,
-                                                  perfmon->values[j]);
-               } else {
-                       for (j = 0; j < perfmon->ncounters; j++)
-                               write_to_buffer_32(data, offset + j,
-                                                  perfmon->values[j]);
-               }
+               for (j = 0; j < perfmon->ncounters; j++)
+                       write_to_buffer(data, offset + j, job->copy.do_64bit, perfmon->values[j]);
 
                v3d_perfmon_put(perfmon);
        }