]> git.hungrycats.org Git - linux/commitdiff
drm/msm/dp: Drop dev_pm_opp_set_rate(0)
authorKonrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Tue, 28 Jul 2026 13:20:46 +0000 (15:20 +0200)
committerDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Fri, 31 Jul 2026 14:08:01 +0000 (17:08 +0300)
dev_pm_opp_set_rate(0) removes the vote specified in required-opps but
does not actually park the clock, making it run without the necessary
power backing. Drop the explicit calls to it.

Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support")
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patchwork: https://patchwork.freedesktop.org/patch/742781/
Link: https://lore.kernel.org/r/20260728-topic-dpu_power-v1-2-e7783b859a70@oss.qualcomm.com
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
drivers/gpu/drm/msm/dp/dp_ctrl.c

index 5d896593771ef7b4399cb6dee563694a24a000ae..59070f399e2d31556943cbd00db66f06df6ebbc7 100644 (file)
@@ -1988,13 +1988,12 @@ static int msm_dp_ctrl_reinitialize_mainlink(struct msm_dp_ctrl_private *ctrl,
        msm_dp_ctrl_mainlink_disable(ctrl);
        ctrl->phy_opts.dp.lanes = ctrl->link->link_params.num_lanes;
        phy_configure(phy, &ctrl->phy_opts);
+
        /*
         * Disable and re-enable the mainlink clock since the
         * link clock might have been adjusted as part of the
         * link maintenance.
         */
-       dev_pm_opp_set_rate(ctrl->dev, 0);
-
        msm_dp_ctrl_link_clk_disable(&ctrl->msm_dp_ctrl);
 
        phy_power_off(phy);
@@ -2021,7 +2020,6 @@ static int msm_dp_ctrl_deinitialize_mainlink(struct msm_dp_ctrl_private *ctrl,
 
        msm_dp_ctrl_reset(&ctrl->msm_dp_ctrl, panel);
 
-       dev_pm_opp_set_rate(ctrl->dev, 0);
        msm_dp_ctrl_link_clk_disable(&ctrl->msm_dp_ctrl);
 
        phy_power_off(phy);
@@ -2656,7 +2654,6 @@ void msm_dp_ctrl_off_link(struct msm_dp_ctrl *msm_dp_ctrl,
 
        msm_dp_ctrl_reset(&ctrl->msm_dp_ctrl, panel);
 
-       dev_pm_opp_set_rate(ctrl->dev, 0);
        msm_dp_ctrl_link_clk_disable(&ctrl->msm_dp_ctrl);
 
        phy_power_off(phy);