]> git.hungrycats.org Git - linux/commitdiff
drm/mxsfb/lcdif: don't hide lcdif_attach_bridge() deferral messages
authorLuca Ceresoli <luca.ceresoli@bootlin.com>
Fri, 19 Jun 2026 07:02:13 +0000 (09:02 +0200)
committerLuca Ceresoli <luca.ceresoli@bootlin.com>
Wed, 1 Jul 2026 17:04:55 +0000 (19:04 +0200)
lcdif_attach_bridge() uses dev_err_probe() on all its error returns to
store a specific deferral message.

However its caller lcdif_load() calls dev_err_probe() again on error,
overwriting the specific deferral messages with a unique, unavoidably
generic, message.

Make the specific deferral message visible by using a plain 'return ret' on
the caller.

Acked-by: Liu Ying <victor.liu@nxp.com>
Link: https://patch.msgid.link/20260619-drm-lcdif-deferral-msg-v1-1-ce2392dca985@bootlin.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
drivers/gpu/drm/mxsfb/lcdif_drv.c

index f5bb59cd50285379914b2e5ba5c347c73ce91715..e2173c4d6fc289687591682e35fbce73b912d3c4 100644 (file)
@@ -186,7 +186,7 @@ static int lcdif_load(struct drm_device *drm)
 
        ret = lcdif_attach_bridge(lcdif);
        if (ret)
-               return dev_err_probe(drm->dev, ret, "Cannot connect bridge\n");
+               return ret;
 
        drm->mode_config.min_width      = LCDIF_MIN_XRES;
        drm->mode_config.min_height     = LCDIF_MIN_YRES;