]> git.hungrycats.org Git - linux/commitdiff
platform/mellanox: nvsw-sn2201: Add check for platform_device_add_resources
authorChen Ni <nichen@iscas.ac.cn>
Wed, 5 Jun 2024 03:27:45 +0000 (11:27 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Jul 2024 07:53:34 +0000 (09:53 +0200)
[ Upstream commit d56fbfbaf592a115b2e11c1044829afba34069d2 ]

Add check for the return value of platform_device_add_resources() and
return the error if it fails in order to catch the error.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Link: https://lore.kernel.org/r/20240605032745.2916183-1-nichen@iscas.ac.cn
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/platform/mellanox/nvsw-sn2201.c

index 3ef655591424c2b8deeff21069dfa893d36322fa..abe7be602f846e3bbed10ff70d1dc111f0651438 100644 (file)
@@ -1198,6 +1198,7 @@ static int nvsw_sn2201_config_pre_init(struct nvsw_sn2201 *nvsw_sn2201)
 static int nvsw_sn2201_probe(struct platform_device *pdev)
 {
        struct nvsw_sn2201 *nvsw_sn2201;
+       int ret;
 
        nvsw_sn2201 = devm_kzalloc(&pdev->dev, sizeof(*nvsw_sn2201), GFP_KERNEL);
        if (!nvsw_sn2201)
@@ -1205,8 +1206,10 @@ static int nvsw_sn2201_probe(struct platform_device *pdev)
 
        nvsw_sn2201->dev = &pdev->dev;
        platform_set_drvdata(pdev, nvsw_sn2201);
-       platform_device_add_resources(pdev, nvsw_sn2201_lpc_io_resources,
+       ret = platform_device_add_resources(pdev, nvsw_sn2201_lpc_io_resources,
                                      ARRAY_SIZE(nvsw_sn2201_lpc_io_resources));
+       if (ret)
+               return ret;
 
        nvsw_sn2201->main_mux_deferred_nr = NVSW_SN2201_MAIN_MUX_DEFER_NR;
        nvsw_sn2201->main_mux_devs = nvsw_sn2201_main_mux_brdinfo;