]> git.hungrycats.org Git - linux/commitdiff
devlink: Enable the use of private flags in post_doit operations
authorIdo Schimmel <idosch@nvidia.com>
Wed, 15 Nov 2023 12:17:12 +0000 (13:17 +0100)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:18:54 +0000 (18:18 -0400)
[ Upstream commit c8d0a7d6152bec970552786b77626f4b4c562f4d ]

Currently, private flags (e.g., 'DEVLINK_NL_FLAG_NEED_PORT') are only
used in pre_doit operations, but a subsequent patch will need to
conditionally lock and unlock the device lock in pre and post doit
operations, respectively.

As a preparation, enable the use of private flags in post_doit
operations in a similar fashion to how it is done for pre_doit
operations.

No functional changes intended.

Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Stable-dep-of: d7d75124965a ("devlink: Fix devlink parallel commands processing")
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/devlink/netlink.c

index 7350138c8bb44497ee7c4ddc11c30f97159980fd..5bb6624f3288e099fbc2df3fafd8d089e10b0c95 100644 (file)
@@ -141,8 +141,8 @@ int devlink_nl_pre_doit_port_optional(const struct genl_split_ops *ops,
        return __devlink_nl_pre_doit(skb, info, DEVLINK_NL_FLAG_NEED_DEVLINK_OR_PORT);
 }
 
-void devlink_nl_post_doit(const struct genl_split_ops *ops,
-                         struct sk_buff *skb, struct genl_info *info)
+static void __devlink_nl_post_doit(struct sk_buff *skb, struct genl_info *info,
+                                  u8 flags)
 {
        struct devlink *devlink;
 
@@ -151,6 +151,12 @@ void devlink_nl_post_doit(const struct genl_split_ops *ops,
        devlink_put(devlink);
 }
 
+void devlink_nl_post_doit(const struct genl_split_ops *ops,
+                         struct sk_buff *skb, struct genl_info *info)
+{
+       __devlink_nl_post_doit(skb, info, 0);
+}
+
 static int devlink_nl_inst_single_dumpit(struct sk_buff *msg,
                                         struct netlink_callback *cb, int flags,
                                         devlink_nl_dump_one_func_t *dump_one,