]> git.hungrycats.org Git - linux/commitdiff
HID: core: zero-initialize the report buffer
authorJiri Kosina <jkosina@suse.com>
Tue, 29 Oct 2024 14:44:35 +0000 (15:44 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 17 Nov 2024 13:59:35 +0000 (14:59 +0100)
[ Upstream commit 177f25d1292c7e16e1199b39c85480f7f8815552 ]

Since the report buffer is used by all kinds of drivers in various ways, let's
zero-initialize it during allocation to make sure that it can't be ever used
to leak kernel memory via specially-crafted report.

Fixes: 27ce405039bf ("HID: fix data access in implement()")
Reported-by: BenoƮt Sevens <bsevens@google.com>
Acked-by: Benjamin Tissoires <bentiss@kernel.org>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/hid/hid-core.c

index 5281d693b32d2d365ebd09a7206064ad18005499..0fef4bdb90f14ae9de72bc97ce08617b4a76d374 100644 (file)
@@ -1664,7 +1664,7 @@ u8 *hid_alloc_report_buf(struct hid_report *report, gfp_t flags)
 
        u32 len = hid_report_len(report) + 7;
 
-       return kmalloc(len, flags);
+       return kzalloc(len, flags);
 }
 EXPORT_SYMBOL_GPL(hid_alloc_report_buf);