]> git.hungrycats.org Git - linux/commitdiff
media: i2c: rdacm21: Fix uninitialized value
authorJacopo Mondi <jacopo.mondi@ideasonboard.com>
Thu, 10 Aug 2023 13:33:37 +0000 (15:33 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 13 Sep 2023 07:48:32 +0000 (09:48 +0200)
[ Upstream commit 33c7ae8f49e3413c81e879e1fdfcea4c5516e37b ]

Fix the following smatch warning:

drivers/media/i2c/rdacm21.c:373 ov10640_check_id() error: uninitialized
symbol 'val'.

Initialize 'val' to 0 in the ov10640_check_id() function.

Fixes: 2b821698dc73 ("media: i2c: rdacm21: Power up OV10640 before OV490")
Reported-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/i2c/rdacm21.c

index 9ccc56c30d3b0acde7a12cdcd9f6a4a60de8882c..d269c541ebe4c7f6ef4aad0bdb56a335ba7428b6 100644 (file)
@@ -351,7 +351,7 @@ static void ov10640_power_up(struct rdacm21_device *dev)
 static int ov10640_check_id(struct rdacm21_device *dev)
 {
        unsigned int i;
-       u8 val;
+       u8 val = 0;
 
        /* Read OV10640 ID to test communications. */
        for (i = 0; i < OV10640_PID_TIMEOUT; ++i) {