]> git.hungrycats.org Git - linux/commitdiff
bpf: Suppress 'passing zero to PTR_ERR' warning
authorKumar Kartikeya Dwivedi <memxor@gmail.com>
Sat, 21 May 2022 13:26:20 +0000 (18:56 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Aug 2022 12:42:35 +0000 (14:42 +0200)
commit 1ec5ee8c8a5a65ea377f8bea64bf4d5b743f6f79 upstream.

Kernel Test Robot complains about passing zero to PTR_ERR for the said
line, suppress it by using PTR_ERR_OR_ZERO.

Fixes: c0a5a21c25f3 ("bpf: Allow storing referenced kptr in map")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20220521132620.1976921-1-memxor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/bpf/verifier.c

index 93c98f95901e5ad82f033b091b26ec3c91673246..839340d4cc29098c2cdf22eda74114de9ea40f1c 100644 (file)
@@ -5327,7 +5327,7 @@ static int process_kptr_func(struct bpf_verifier_env *env, int regno,
                return -EINVAL;
        }
        if (!map_value_has_kptrs(map_ptr)) {
-               ret = PTR_ERR(map_ptr->kptr_off_tab);
+               ret = PTR_ERR_OR_ZERO(map_ptr->kptr_off_tab);
                if (ret == -E2BIG)
                        verbose(env, "map '%s' has more than %d kptr\n", map_ptr->name,
                                BPF_MAP_VALUE_OFF_MAX);