]> git.hungrycats.org Git - linux/commitdiff
perf pmu: Fix misleadingly indented assignment (whitespace)
authorMarkus Trippelsdorf <markus@trippelsdorf.de>
Mon, 14 Dec 2015 15:44:40 +0000 (16:44 +0100)
committerSasha Levin <alexander.levin@verizon.com>
Mon, 31 Jul 2017 17:37:53 +0000 (13:37 -0400)
[ Upstream commit d85ce830eef6c10d1e9617172dea4681f02b8424 ]

One line in perf_pmu__parse_unit() is indented wrongly, leading to a
warning (=> error) from gcc 6:

  util/pmu.c:156:3: error: statement is indented as if it were guarded by... [-Werror=misleading-indentation]

    sret = read(fd, alias->unit, UNIT_MAX_LEN);
    ^~~~

  util/pmu.c:153:2: note: ...this 'if' clause, but it is not
    if (fd == -1)
    ^~

Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de>
Acked-by: Ingo Molnar <mingo@kernel.org>
Cc: Ben Hutchings <ben@decadent.org.uk>
Cc: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Peter Zijlstra <peterz@infradead.org>
Fixes: 410136f5dd96 ("tools/perf/stat: Add event unit and scale support")
Link: http://lkml.kernel.org/r/20151214154440.GC1409@x4
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
tools/perf/util/pmu.c

index 8b02a43556591bfcd93f70c019aec85c1bb75068..3297d7e85dd7b9defc4189afeb2a66dcf661a34d 100644 (file)
@@ -148,7 +148,7 @@ static int perf_pmu__parse_unit(struct perf_pmu_alias *alias, char *dir, char *n
        if (fd == -1)
                return -1;
 
-               sret = read(fd, alias->unit, UNIT_MAX_LEN);
+       sret = read(fd, alias->unit, UNIT_MAX_LEN);
        if (sret < 0)
                goto error;