[PATCH] vga16fb.c: fix bogus mem_start value

From: Herbert Xu <herbert@gondor.apana.org.au>

The recent change to vga16fb's memory mapping that you partially reverted
is still broken.  In particular, it's setting fix.mem_start to a virtual
address on i386.  The value of fix.mem_start is meant to be physical.

We could simply apply virt_to_phys to it, but somehow I doubt that is what
it's meant to do on arm.  So until we hear from someone who knows how it
works on arm, let's just revert this change.

Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
index 820769e1bed67b04b2ae1079e1c6b56580c56945..bdcc8ecef92c5fd7f62f83e29450c4e769a55de8 100644 (file)
--- a/drivers/video/vga16fb.c
+++ b/drivers/video/vga16fb.c
@@ -1372,8 +1372,6 @@ int __init vga16fb_init(void)
        vga16fb.par = &vga16_par;
        vga16fb.flags = FBINFO_FLAG_DEFAULT;
 
-       vga16fb.fix.smem_start  = VGA_MAP_MEM(vga16fb.fix.smem_start);
-
        i = (vga16fb_defined.bits_per_pixel == 8) ? 256 : 16;
        ret = fb_alloc_cmap(&vga16fb.cmap, i, 0);
        if (ret) {