]> git.hungrycats.org Git - linux/commitdiff
mac80211: flush delayed work when entering suspend
authorMatt Chen <matt.chen@intel.com>
Sat, 21 Jan 2017 18:16:58 +0000 (02:16 +0800)
committerBen Hutchings <ben@decadent.org.uk>
Mon, 5 Jun 2017 20:17:17 +0000 (21:17 +0100)
commit a9e9200d8661c1a0be8c39f93deb383dc940de35 upstream.

The issue was found when entering suspend and resume.
It triggers a warning in:
mac80211/key.c: ieee80211_enable_keys()
...
WARN_ON_ONCE(sdata->crypto_tx_tailroom_needed_cnt ||
             sdata->crypto_tx_tailroom_pending_dec);
...

It points out sdata->crypto_tx_tailroom_pending_dec isn't cleaned up successfully
in a delayed_work during suspend. Add a flush_delayed_work to fix it.

Signed-off-by: Matt Chen <matt.chen@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/mac80211/pm.c

index 090bdf11caed3794850f0549fe2dcbb6b99b98a5..c5706b0bb6837d32b34a81258774a98138b5c018 100644 (file)
@@ -114,6 +114,7 @@ int __ieee80211_suspend(struct ieee80211_hw *hw, struct cfg80211_wowlan *wowlan)
                        break;
                }
 
+               flush_delayed_work(&sdata->dec_tailroom_needed_wk);
                drv_remove_interface(local, sdata);
        }