]> git.hungrycats.org Git - linux/commitdiff
iio:bma180: Missing check for frequency fractional part
authorPeter Meerwald <pmeerw@pmeerw.net>
Wed, 16 Jul 2014 18:32:00 +0000 (19:32 +0100)
committerJiri Slaby <jslaby@suse.cz>
Tue, 19 Aug 2014 12:23:36 +0000 (14:23 +0200)
commit 9b2a4d35a6ceaf217be61ed8eb3c16986244f640 upstream.

val2 should be zero

This will make no difference for correct inputs but will reject
incorrect ones with a decimal part in the value written to the sysfs
interface.

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Cc: Oleksandr Kravchenko <o.v.kravchenko@globallogic.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/iio/accel/bma180.c

index 225aea63eaf5310c3584678997e97ea437ba7ecf..60a3bab42263a2784a67e8ec3fb095b6424fd5fa 100644 (file)
@@ -376,6 +376,8 @@ static int bma180_write_raw(struct iio_dev *indio_dev,
                mutex_unlock(&data->mutex);
                return ret;
        case IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY:
+               if (val2)
+                       return -EINVAL;
                mutex_lock(&data->mutex);
                ret = bma180_set_bw(data, val);
                mutex_unlock(&data->mutex);