]> git.hungrycats.org Git - linux/commitdiff
arm64: dts: rockchip: Fix LED triggers on rk3308-roc-cc
authorHeiko Stuebner <heiko@sntech.de>
Tue, 8 Oct 2024 20:39:33 +0000 (22:39 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 17 Nov 2024 13:59:34 +0000 (14:59 +0100)
[ Upstream commit 3a53a7187f41ec3db12cf4c2cb0db4ba87c2f3a1 ]

There are two LEDs on the board, power and user events.
Currently both are assigned undocumented IR(-remote)
triggers that are probably only part of the vendor-kernel.

To make dtbs check happier, assign the power-led to a generic
default-on trigger and the user led to the documented rc-feedback
trigger that should mostly match its current usage.

Fixes: 4403e1237be3 ("arm64: dts: rockchip: Add devicetree for board roc-rk3308-cc")
Cc: Andy Yan <andy.yan@rock-chips.com>
Reviewed-by: Dragan Simic <dsimic@manjaro.org>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20241008203940.2573684-8-heiko@sntech.de
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts

index 213c0759c4b8528981727a818dc67a33901fc8ad..bf09b2818e20d7e1f6d0df18d58cc77d1462e5d4 100644 (file)
 
                power_led: led-0 {
                        label = "firefly:red:power";
-                       linux,default-trigger = "ir-power-click";
+                       linux,default-trigger = "default-on";
                        default-state = "on";
                        gpios = <&gpio0 RK_PA6 GPIO_ACTIVE_HIGH>;
                };
 
                user_led: led-1 {
                        label = "firefly:blue:user";
-                       linux,default-trigger = "ir-user-click";
+                       linux,default-trigger = "rc-feedback";
                        default-state = "off";
                        gpios = <&gpio0 RK_PB2 GPIO_ACTIVE_HIGH>;
                };