]> git.hungrycats.org Git - linux/commitdiff
serial: 8250_fintek: Fix finding base_port with activated SuperIO
authorJi-Ze Hong (Peter Hong) <hpeter@gmail.com>
Tue, 17 Oct 2017 06:23:08 +0000 (14:23 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 24 Nov 2017 07:33:42 +0000 (08:33 +0100)
commit fd97e66c5529046e989a0879c3bb58fddb592c71 upstream.

The SuperIO will be configured at boot time by BIOS, but some BIOS
will not deactivate the SuperIO when the end of configuration. It'll
lead to mismatch for pdata->base_port in probe_setup_port(). So we'll
deactivate all SuperIO before activate special base_port in
fintek_8250_enter_key().

Tested on iBASE MI802.

Tested-by: Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@gmail.com>
Signed-off-by: Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@gmail.com>
Reviewd-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_fintek.c

index 0facc789fe7d4133e1c5e32d0a471db53bb3baa5..f8c31070a3371ebb313b86a4912afc0a06ec96ab 100644 (file)
@@ -54,6 +54,9 @@ static int fintek_8250_enter_key(u16 base_port, u8 key)
        if (!request_muxed_region(base_port, 2, "8250_fintek"))
                return -EBUSY;
 
+       /* Force to deactive all SuperIO in this base_port */
+       outb(EXIT_KEY, base_port + ADDR_PORT);
+
        outb(key, base_port + ADDR_PORT);
        outb(key, base_port + ADDR_PORT);
        return 0;