]> git.hungrycats.org Git - linux/commitdiff
[PATCH] Fix leaks in ISOFS.
authorDave Jones <davej@redhat.com>
Thu, 2 Sep 2004 07:38:05 +0000 (00:38 -0700)
committerLinus Torvalds <torvalds@ppc970.osdl.org>
Thu, 2 Sep 2004 07:38:05 +0000 (00:38 -0700)
Spotted with the source checker from Coverity.com.

Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
fs/isofs/rock.c

index c09d4bd4b55a7451782f22d413434352830233dc..29f8e308ba2bccd2f7e4de6bfca58a2ae281cb52 100644 (file)
@@ -153,6 +153,7 @@ int get_rock_ridge_filename(struct iso_directory_record * de,
     }
   }
   MAYBE_CONTINUE(repeat,inode);
+  if (buffer) kfree(buffer);
   return retnamlen; /* If 0, this file did not have a NM field */
  out:
   if(buffer) kfree(buffer);
@@ -351,7 +352,6 @@ int parse_rock_ridge_inode_internal(struct iso_directory_record * de,
     }
   }
   MAYBE_CONTINUE(repeat,inode);
-  return 0;
  out:
   if(buffer) kfree(buffer);
   return 0;
@@ -515,6 +515,8 @@ static int rock_ridge_symlink_readpage(struct file *file, struct page *page)
                }
        }
        MAYBE_CONTINUE(repeat, inode);
+       if (buffer)
+               kfree(buffer);
 
        if (rpnt == link)
                goto fail;