[PATCH] pcnet32: fix boundary comparison bug.

This patch fixes a boundary condition.  It is possible to get an
interrupt and have the transmit queue completely full.  Without this
the driver will leak skb's and pci maps (if the arch supports them).

diff --git a/drivers/net/pcnet32.c b/drivers/net/pcnet32.c
index 72938087cc51c82af4500d16cdea2ffe5a30c2ad..08350723f70510a32c5d03e42119a53181c8a4c4 100644 (file)
--- a/drivers/net/pcnet32.c
+++ b/drivers/net/pcnet32.c
@@ -1833,7 +1833,7 @@ pcnet32_interrupt(int irq, void *dev_id, struct pt_regs * regs)
            }
 
            delta = (lp->cur_tx - dirty_tx) & (TX_RING_MOD_MASK + TX_RING_SIZE);
-           if (delta >= TX_RING_SIZE) {
+           if (delta > TX_RING_SIZE) {
                if (netif_msg_drv(lp))
                    printk(KERN_ERR "%s: out-of-sync dirty pointer, %d vs. %d, full=%d.\n",
                            dev->name, dirty_tx, lp->cur_tx, lp->tx_full);