[PATCH] rename make check* targets, add versioncheck

rename make check* targets to make *check (per Sam) since 'make
checkconfig' currently doesn't work; add versioncheck and
scripts/checkversion.pl;

diff --git a/Makefile b/Makefile
index 72ac347919327b0d67fb52bc7738b7a4fa8a7ac2..8de47cdd37725696e72a2b9a23e66abd622c8c5b 100644 (file)
--- a/Makefile
+++ b/Makefile
@@ -828,16 +828,21 @@ help:
 # Scripts to check various things for consistency
 # ---------------------------------------------------------------------------
 
-checkconfig:
+configcheck:
        find * $(RCS_FIND_IGNORE) \
                -name '*.[hcS]' -type f -print | sort \
                | xargs $(PERL) -w scripts/checkconfig.pl
 
-checkincludes:
+includecheck:
        find * $(RCS_FIND_IGNORE) \
                -name '*.[hcS]' -type f -print | sort \
                | xargs $(PERL) -w scripts/checkincludes.pl
 
+versioncheck:
+       find * $(RCS_FIND_IGNORE) \
+               -name '*.[hcS]' -type f -print | sort \
+               | xargs $(PERL) -w scripts/checkversion.pl
+
 endif #ifeq ($(config-targets),1)
 endif #ifeq ($(mixed-targets),1)
 

diff --git a/scripts/checkversion.pl b/scripts/checkversion.pl
new file mode 100644 (file)
index 0000000..df10db6
--- /dev/null
+++ b/scripts/checkversion.pl
@@ -0,0 +1,72 @@
+#! /usr/bin/perl
+#
+# checkversion find uses of LINUX_VERSION_CODE, KERNEL_VERSION, or
+# UTS_RELEASE without including <linux/version.h>, or cases of
+# including <linux/version.h> that don't need it.
+# Copyright (C) 2003, Randy Dunlap <rddunlap@osdl.org>
+
+$| = 1;
+
+my $debugging = 0;
+
+foreach $file (@ARGV)
+{
+    # Open this file.
+    open(FILE, $file) || die "Can't open $file: $!\n";
+
+    # Initialize variables.
+    my $fInComment   = 0;
+    my $fInString    = 0;
+    my $fUseVersion   = 0;
+    my $iLinuxVersion = 0;
+
+    LINE: while ( <FILE> )
+    {
+       # Strip comments.
+       $fInComment && (s+^.*?\*/+ +o ? ($fInComment = 0) : next);
+       m+/\*+o && (s+/\*.*?\*/+ +go, (s+/\*.*$+ +o && ($fInComment = 1)));
+
+       # Pick up definitions.
+       if ( m/^\s*#/o ) {
+           $iLinuxVersion      = $. if m/^\s*#\s*include\s*"linux\/version\.h"/o;
+       }
+
+       # Strip strings.
+       $fInString && (s+^.*?"+ +o ? ($fInString = 0) : next);
+       m+"+o && (s+".*?"+ +go, (s+".*$+ +o && ($fInString = 1)));
+
+       # Pick up definitions.
+       if ( m/^\s*#/o ) {
+           $iLinuxVersion      = $. if m/^\s*#\s*include\s*<linux\/version\.h>/o;
+       }
+
+       # Look for uses: LINUX_VERSION_CODE, KERNEL_VERSION, UTS_RELEASE
+       if (($_ =~ /LINUX_VERSION_CODE/) || ($_ =~ /\WKERNEL_VERSION/) ||
+               ($_ =~ /UTS_RELEASE/)) {
+           $fUseVersion = 1;
+           last LINE if $iLinuxVersion;
+       }
+    }
+
+    # Report used version IDs without include?
+    if ($fUseVersion && ! $iLinuxVersion) {
+       print "$file: $.: need linux/version.h\n";
+    }
+
+    # Report superfluous includes.
+    if ($iLinuxVersion && ! $fUseVersion) {
+       print "$file: $iLinuxVersion linux/version.h not needed.\n";
+    }
+
+    # debug: report OK results:
+    if ($debugging) {
+        if ($iLinuxVersion && $fUseVersion) {
+           print "$file: version use is OK ($iLinuxVersion)\n";
+        }
+        if (! $iLinuxVersion && ! $fUseVersion) {
+           print "$file: version use is OK (none)\n";
+        }
+    }
+
+    close(FILE);
+}