[PATCH] USB: fixes for usb-skeleton.c

I've found minor errors in usb-skeleton.c. First, there is no valid
value of interface->minor in assignment to dev->minor. Second, when
calling usb_deregister_dev the interface->minor must be valid or else
minor isn't deregistered.

diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c
index 1a7c8cbf584bea575aae8aaf4d746d98ed84f0ac..271804d2089f6b2631ede92a0e16290d4418a253 100644 (file)
--- a/drivers/usb/usb-skeleton.c
+++ b/drivers/usb/usb-skeleton.c
@@ -526,7 +526,6 @@ static int skel_probe(struct usb_interface *interface, const struct usb_device_i
        init_MUTEX (&dev->sem);
        dev->udev = udev;
        dev->interface = interface;
-       dev->minor = interface->minor;
 
        /* set up the endpoint information */
        /* check out the endpoints */
@@ -606,6 +605,7 @@ static int skel_probe(struct usb_interface *interface, const struct usb_device_i
                goto error;
        }
 
+       dev->minor = interface->minor;
 
        /* let the user know what node this device is now attached to */
        info ("USB Skeleton device now attached to USBSkel-%d", dev->minor);
@@ -641,9 +641,6 @@ static void skel_disconnect(struct usb_interface *interface)
 
        down (&dev->sem);
 
-       /* disable open() */
-       interface->minor = -1;
-
        minor = dev->minor;
 
        /* give back our minor */