]> git.hungrycats.org Git - linux/commitdiff
staging: rtl8192e: Fix log spamming in rtl8192_hard_data_xmit
authorMateusz Kulikowski <mateusz.kulikowski@gmail.com>
Wed, 12 Aug 2015 19:54:49 +0000 (21:54 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 21 Sep 2015 17:10:45 +0000 (10:10 -0700)
commit 435009bba4d0449b611bc24ae5c9636ac5b2a00e upstream.

This patch fixes issue generated by commit ca93dcba3a92
("staging: rtl8192e: Remove assert() macro")

One negation was missed in conversion, therefore
asserted message was always printed.
For 1MB file downloaded via http, ~500 messages
were generated.

Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtl8192e/rtl_core.c

index c6cdb43b864c1996813c5d83b0042416335f71f7..476808261fa8c922cc486f5587d9d864c0705f1a 100644 (file)
@@ -1826,8 +1826,8 @@ void rtl8192_hard_data_xmit(struct sk_buff *skb, struct net_device *dev,
                return;
        }
 
-       if (queue_index != TXCMD_QUEUE)
-               netdev_warn(dev, "%s(): queue index != TXCMD_QUEUE\n",
+       if (queue_index == TXCMD_QUEUE)
+               netdev_warn(dev, "%s(): queue index == TXCMD_QUEUE\n",
                            __func__);
 
        memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev));