]> git.hungrycats.org Git - linux/commitdiff
ASoC: mxs-saif: Drop redundant probe error messages
authorbui duc phuc <phucduc.bui@gmail.com>
Wed, 12 Aug 2026 10:14:17 +0000 (17:14 +0700)
committerMark Brown <broonie@kernel.org>
Wed, 12 Aug 2026 17:37:45 +0000 (18:37 +0100)
The functions called here don't log the error themselves, but the
error is already reported deeper in the call chain, so the dev_err()
calls are redundant and can be removed.

Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
Link: https://patch.msgid.link/20260812101418.37966-3-phucduc.bui@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/mxs/mxs-saif.c

index b877c978a04c62cb23568309c6e8ba7c8619b966..a77cd516a1bfd2de7f81df219a69af186307bb68 100644 (file)
@@ -841,10 +841,8 @@ static int mxs_saif_probe(struct platform_device *pdev)
        saif->dev = &pdev->dev;
        ret = devm_request_irq(&pdev->dev, irq, mxs_saif_irq, 0,
                               dev_name(&pdev->dev), saif);
-       if (ret) {
-               dev_err(&pdev->dev, "failed to request irq\n");
+       if (ret)
                return ret;
-       }
 
        platform_set_drvdata(pdev, saif);
 
@@ -857,16 +855,12 @@ static int mxs_saif_probe(struct platform_device *pdev)
 
        ret = devm_snd_soc_register_component(&pdev->dev, &mxs_saif_component,
                                              &mxs_saif_dai, 1);
-       if (ret) {
-               dev_err(&pdev->dev, "register DAI failed\n");
+       if (ret)
                return ret;
-       }
 
        ret = mxs_pcm_platform_register(&pdev->dev);
-       if (ret) {
-               dev_err(&pdev->dev, "register PCM failed: %d\n", ret);
+       if (ret)
                return ret;
-       }
 
        return 0;
 }